[gui-dev] Search columns

[M. Vernier]

Hello,

I would like to implement search columns specific to each type of
search so that Audio columns only appear for an Audio search and
Video columns only appear for a Video search. Also, I would like to
provide reasonable default values for the column order.
Eg. Title, Artist and Album would come first for an audio search
because they are more pertinent for the end user.

I have looked at the code and as I understand things, I would need
to:

- extend ResultPanel: AudioResultPanel, VideoResultPanel...
- extend either ResultPanelModel or BasicDataLineModel in order to
benefit from specific SearchTableColumns: AudioSearchTableColumns,
VideoSearchTableColumns...

Am I right and would that make a valuable contribution?

M. Vernier

[Sam Berlin]

Hi M Vernier,

It would indeed be a valuable addition if the default visible columns for specific kinds of searches were different. I don't know if this should extend to being the only visible columns -- perhaps the 'Any Type' search should remain having all of them available.

You're correct in that AudioSearchTableColumns, VideoSearchTableColumns, etc... would be a good way of doing it. Keep in mind that almost all of this information is extensible (via dropping new XSD schemas in), so perhaps a better way to do it would be having an XMLSearchTableColumns that took an XSD schema and internally created only the columns for that schema, and then having multiple instances of that object with different schemas sent to the constructors.

I'm not certain if extending ResultPanelModel or ResultPanel is necessary. What do you have in mind for these classes?

The only catch I can think of that you'll run into is the saving of the column widths/order/visibility between sessions. You'll have to come up with a way to give a unique name to each different kind of search.

Having a more reasonable default order would be excellent. The catch with that is that many results may come in that do not have the metadata completed, and thus the filename is the only resource left. Perhaps the filename could be parsed for guessing at the metadata? Or the Title column could contain the filename if there was no other metadata (or just the title) available?

We have planned this kind of change for a while, so it would be truly wonderful to see it added.

Thanks,
Sam

---------- Original Message ----------------------------------
From: "M. Vernier" <***@freeshell.org>
Reply-To: ***@gui.limewire.org
Date: Thu, 16 Sep 2004 15:53:58 +0200

Post by M. Vernier
Hello,
I would like to implement search columns specific to each type of
search so that Audio columns only appear for an Audio search and
Video columns only appear for a Video search. Also, I would like to
provide reasonable default values for the column order.
Eg. Title, Artist and Album would come first for an audio search
because they are more pertinent for the end user.
I have looked at the code and as I understand things, I would need
- extend ResultPanel: AudioResultPanel, VideoResultPanel...
- extend either ResultPanelModel or BasicDataLineModel in order to
benefit from specific SearchTableColumns: AudioSearchTableColumns,
VideoSearchTableColumns...
Am I right and would that make a valuable contribution?
M. Vernier
_______________________________________________
gui-dev mailing list
http://www.limewire.org/mailman/listinfo/gui-dev

[Gregorio Roper]

Post by M. Vernier
Hello,
I would like to implement search columns specific to each type of
search so that Audio columns only appear for an Audio search and
Video columns only appear for a Video search. Also, I would like to
provide reasonable default values for the column order.
Eg. Title, Artist and Album would come first for an audio search
because they are more pertinent for the end user.
I have looked at the code and as I understand things, I would need
- extend ResultPanel: AudioResultPanel, VideoResultPanel...
- extend either ResultPanelModel or BasicDataLineModel in order to
benefit from specific SearchTableColumns: AudioSearchTableColumns,
VideoSearchTableColumns...
Am I right and would that make a valuable contribution?
M. Vernier

Make sure you can still choose to show all columns for ANY_TYPE searches.

I'm not sure whether it would be exactly a valuable contribution, - I can't
remember any feature request at gnutellaforums.com of that kind. As a user I
would probably prefer it if LimeWire saved which search columns I want it to
show for every search type independently instead of taking away my freedom to
view Producer, Stars and Subtitle information for my audio searches :-)

mfg
gregorio

[M. Vernier]

No, it would not be the only visible columns, it would just be the default.
If you are an advanced user, you would be given the possibility to add those
technical columns and even hide the xml ones.
I like the idea of XMLSearchTableColumns taking XSD schemas. This
would allow great flexibility in defining how we want to present the
columns.
Extending ResultPanelModel is not necessary but the constructor(s)
should take a parameter “columns” being the XMLSearchTableColumns to use.
How to save the different settings for each view? Right now,
SearchTableColumns uses a prefix “RESULT_PANEL” for each line saved in
tables.props. This prefix could be part of the schema or
XMLSearchTableColumns could take another parameter which would be this
prefix.
For Audio SearchTableColumns, we would just have:
XMLSearchTableColumns(‘audio_search_table_columns.xsd’)

or

XMLSearchTableColumns(‘AUDIO_RESULT_PANEL’,
‘audio_search_table_columns.xsd’)

M. Vernier