Discussion:
[gui-dev] "Ability to send download filename to search box"
Marcin Okraszewszki
2005-05-12 13:53:33 UTC
Permalink
Hi,
What do you mean by this exactly? You mean ritght click at a file being
downloaded and choose "search it"? If this is a point, I can do it.

Marcin
Sam Berlin
2005-05-12 13:59:25 UTC
Permalink
Hi Marcin,

The ideal solution to this would remember what query was used to
search/download a particular file and offer the user the option to either
search with that phrase or one built up from the words of the download.
Beyond that, yes -- right-click a file being downloaded and choose 'search
it' (just with those options).

Thanks,
Sam
-----Original Message-----
Marcin Okraszewszki
Sent: Thursday, May 12, 2005 9:54 AM
Subject: [gui-dev] "Ability to send download filename to search box"
Hi,
What do you mean by this exactly? You mean ritght click at a
file being downloaded and choose "search it"? If this is a
point, I can do it.
Marcin
_______________________________________________
gui-dev mailing list
http://www.limewire.org/mailman/listinfo/gui-dev
Marcin Okraszewszki
2005-05-12 14:20:28 UTC
Permalink
Hi Sam,
There won't be any problem with searching only for a file. I'll have to
take a deeper look into ability to keep previous search criteria. I'll
check it in a meanwhile.

Regards,
Marcin
Post by Sam Berlin
Hi Marcin,
The ideal solution to this would remember what query was used to
search/download a particular file and offer the user the option to either
search with that phrase or one built up from the words of the download.
Beyond that, yes -- right-click a file being downloaded and choose 'search
it' (just with those options).
Thanks,
Sam
-----Original Message-----
Marcin Okraszewszki
Sent: Thursday, May 12, 2005 9:54 AM
Subject: [gui-dev] "Ability to send download filename to search box"
Hi,
What do you mean by this exactly? You mean ritght click at a
file being downloaded and choose "search it"? If this is a
point, I can do it.
Marcin
_______________________________________________
gui-dev mailing list
http://www.limewire.org/mailman/listinfo/gui-dev
_______________________________________________
gui-dev mailing list
http://www.limewire.org/mailman/listinfo/gui-dev
Marcin Okraszewszki
2005-05-13 07:13:55 UTC
Permalink
Hi Sam,
I have done the searching for a name of downloaded file. But I have a
question about researching by an orginal query. Far I got into the code,
the only information I can obtain in download list is instance of
com.limegroup.gnutella.Downloader (to be more precise:
com.limegroup.gnutella.downloader.ManagedDownloader), which is available
in DownloadDataLine. Far I see ManagedDownloader do not have any
information about orginal query. The ManagedDownloader seems to be saved
between Gnutella runs. So the solution would be to add the orginal query
to ManagedDownloader. Can you point me if is it the right way, or maybe
there is some better solution?

Thanks for help.
Marcin
Post by Sam Berlin
Hi Marcin,
The ideal solution to this would remember what query was used to
search/download a particular file and offer the user the option to either
search with that phrase or one built up from the words of the download.
Beyond that, yes -- right-click a file being downloaded and choose 'search
it' (just with those options).
Thanks,
Sam
-----Original Message-----
Marcin Okraszewszki
Sent: Thursday, May 12, 2005 9:54 AM
Subject: [gui-dev] "Ability to send download filename to search box"
Hi,
What do you mean by this exactly? You mean ritght click at a
file being downloaded and choose "search it"? If this is a
point, I can do it.
Marcin
_______________________________________________
gui-dev mailing list
http://www.limewire.org/mailman/listinfo/gui-dev
_______________________________________________
gui-dev mailing list
http://www.limewire.org/mailman/listinfo/gui-dev
Gregorio Roper
2005-05-13 09:46:09 UTC
Permalink
If you want to remember the original query you might probably want to
store it in the RemoteFileDesc instances either when you pass it from
SearchMediator#doDownload(...) to RouterService#download(....) [see also
ResultPanel, SearchInformation classes] OR you could store that
information by default in all RemoteFileDesc instances when you handle
them through the SearchResultHandler.

The RemoteFileDesc contains an empty map which is currently not used for
anything at all, I'd probably store the query string there to avoid
issues with backwards compatibility.

mfg
gregorio
Post by Marcin Okraszewszki
Hi Sam,
I have done the searching for a name of downloaded file. But I have a
question about researching by an orginal query. Far I got into the code,
the only information I can obtain in download list is instance of
com.limegroup.gnutella.downloader.ManagedDownloader), which is available
in DownloadDataLine. Far I see ManagedDownloader do not have any
information about orginal query. The ManagedDownloader seems to be saved
between Gnutella runs. So the solution would be to add the orginal query
to ManagedDownloader. Can you point me if is it the right way, or maybe
there is some better solution?
s***@limepeer.com
2005-05-13 13:19:35 UTC
Permalink
Hi Marcin,

Looks like you're on the right path. As Gregorio mentioned, RemoteFileDesc
might be a place for that (although it may not be the best, because it'll be
duplicated on every RFD). ManagedDownloader may indeed be better, storing it
as some extraneous "searchPhrase" parameter. The Downloader interface may have
to some new methods added to expose retrieving the new variable.

Thanks,
Sam
Post by Marcin Okraszewszki
Hi Sam,
I have done the searching for a name of downloaded file. But I have a
question about researching by an orginal query. Far I got into the code,
the only information I can obtain in download list is instance of
com.limegroup.gnutella.downloader.ManagedDownloader), which is available
in DownloadDataLine. Far I see ManagedDownloader do not have any
information about orginal query. The ManagedDownloader seems to be saved
between Gnutella runs. So the solution would be to add the orginal query
to ManagedDownloader. Can you point me if is it the right way, or maybe
there is some better solution?
Thanks for help.
Marcin
Post by Sam Berlin
Hi Marcin,
The ideal solution to this would remember what query was used to
search/download a particular file and offer the user the option to either
search with that phrase or one built up from the words of the download.
Beyond that, yes -- right-click a file being downloaded and choose 'search
it' (just with those options).
Thanks,
Sam
-----Original Message-----
Marcin Okraszewszki
Sent: Thursday, May 12, 2005 9:54 AM
Subject: [gui-dev] "Ability to send download filename to search box"
Hi,
What do you mean by this exactly? You mean ritght click at a
file being downloaded and choose "search it"? If this is a
point, I can do it.
Marcin
_______________________________________________
gui-dev mailing list
http://www.limewire.org/mailman/listinfo/gui-dev
_______________________________________________
gui-dev mailing list
http://www.limewire.org/mailman/listinfo/gui-dev
_______________________________________________
gui-dev mailing list
http://www.limewire.org/mailman/listinfo/gui-dev
Marcin Okraszewski
2005-07-17 21:38:03 UTC
Permalink
Hi,
I finally found some time to fit the patch into the new download pop up
menu. It seems to work fine again. The attached patches contains grouped
changes per project.

Best regards,
Marcin Okraszewski
Post by Sam Berlin
Could you inform me if the branch which removes the DownloadPopupMenu is
merged into the main trunk?
Hi Marcin,
the respective branch has been merged in the meantime.
But, FYI, I refactored the SearchForKeyWordAction to be more generic in
another branch, it now also takes a searchinformation object as argument and
searchinformation objects can have a title different from the query text.
Here's a link to the new SearchAction, except for the name it provides the
same arguments as the old one, so you don't have to wait for that branch to
be merged in, in case you want to make use of that action.
http://www.limewire.org/fisheye/viewrep/limecvs/gui/com/limegroup/gnutella/gui/actions/SearchAction.java?r=1.1.2.2
Regards,
Felix
Marcin Okraszewszki
2005-07-18 07:18:54 UTC
Permalink
Here is an other attempt to do it with usage of SearchAction (there is
difference only in DownloadMediator, so I send a patch only for this).

Well, I don't know which is better. The advantage is that it uses the
same code to perform search - less maintenance if anything in search is
changed. On the other hand for me the solution is not that clear and
some preparing operations are done every time the menu is constructed,
not only in case an item was selected (eg. preparing the file name,
creating the original search information).

Well, judge it.

Regards,
Marcin Okraszewski
Post by Marcin Okraszewski
Hi,
I finally found some time to fit the patch into the new download pop up
menu. It seems to work fine again. The attached patches contains grouped
changes per project.
Best regards,
Marcin Okraszewski
Loading...