Philippe Verdy
2004-08-12 11:37:09 UTC
From: "Roger Kapsi" <***@kapsi.de>
To: <***@limewire.org>
Sent: Wednesday, August 11, 2004 10:28 PM
Subject: Re: [codepatch] Java Update for OSX fixes DnD bug
1.5.*
If you really want to test all broken versions before 1.4.2_05 on MacOSX,
you need to test it like this in a single line:
+ private boolean isOSXAndDnDIsBroken() {
+ return CommonUtils.isMacOSX() &&
+ version.compareTo("1.4.2_05") < 0;
+ }
To: <***@limewire.org>
Sent: Wednesday, August 11, 2004 10:28 PM
Subject: Re: [codepatch] Java Update for OSX fixes DnD bug
And this patch is even better! :) Java 1.4.2_00 doesn't exist so it
makes no sense to check for it.
Roger
Not even better: your test will return that DnD is broken on Java 1.4.3 ormakes no sense to check for it.
Roger
1.5.*
If you really want to test all broken versions before 1.4.2_05 on MacOSX,
you need to test it like this in a single line:
+ private boolean isOSXAndDnDIsBroken() {
+ return CommonUtils.isMacOSX() &&
+ version.compareTo("1.4.2_05") < 0;
+ }